Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flow definitions #2053

Closed
AndreyBelym opened this issue Jan 18, 2018 · 2 comments
Closed

Update flow definitions #2053

AndreyBelym opened this issue Jan 18, 2018 · 2 comments
Assignees
Labels
AREA: repo/workflow STATE: Auto-locked An issue has been automatically locked by the Lock bot. TYPE: bug The described behavior is considered as wrong (bug).
Milestone

Comments

@AndreyBelym
Copy link
Contributor

AndreyBelym commented Jan 18, 2018

Are you requesting a feature or reporting a bug?

Bug (https://testcafe-discuss.devexpress.com/t/735)

What is the current behavior?

Flow definitions cause errors when used against flow@0.63.1:

Library type error:
flow-typed/npm/testcafe_v0.x.x.js:205
205: declare interface TestCafe$CustomMethodsSelectorPromiseI<T> extends TestCafe$SelectorAPI, Promise<TestCafe$NodeSnapshot & $ObjMap<T, TestCafe$CustomMethodsTypeTransform>> {
                                                                                                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ TestCafe$CustomMethodsTypeTransform. Could not resolve name

Library type error:
flow-typed/npm/testcafe_v0.x.x.js:266
266:         ((...args: any[]) => Node | Node[] | NodeList | HTMLCollection),
                                                  ^^^^^^^^ NodeList. Application of polymorphic type needs <list of 1 argument>. (Can use `*` for inferrable ones)

Library type error:
flow-typed/npm/testcafe_v0.x.x.js:266
266:         ((...args: any[]) => Node | Node[] | NodeList | HTMLCollection),
                                                             ^^^^^^^^^^^^^^ HTMLCollection. Application of polymorphic type needs <list of 1 argument>. (Can use `*` for inferrable ones)

What is the expected behavior?

The definitions must work without errors against actual flow versions.

How would you reproduce the current behavior (if this is a bug)?

Provide the test code and the tested page URL (if applicable)

Tested page URL:

Test code

Specify your

  • operating system:
  • testcafe version:
  • node.js version:
@AndreyBelym AndreyBelym added TYPE: bug The described behavior is considered as wrong (bug). AREA: repo/workflow labels Jan 18, 2018
@AndreyBelym AndreyBelym modified the milestones: Planned, Sprint #13 Jun 21, 2018
@AndreyBelym AndreyBelym self-assigned this Jun 21, 2018
@AndreyBelym
Copy link
Contributor Author

Closed by flow-typed/flow-typed#2458

@lock
Copy link

lock bot commented Mar 28, 2019

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.

@lock lock bot added the STATE: Auto-locked An issue has been automatically locked by the Lock bot. label Mar 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
AREA: repo/workflow STATE: Auto-locked An issue has been automatically locked by the Lock bot. TYPE: bug The described behavior is considered as wrong (bug).
Projects
None yet
Development

No branches or pull requests

1 participant