Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] Make the code stricter #30

Closed
6 of 8 tasks
devmoath opened this issue Nov 23, 2022 · 0 comments
Closed
6 of 8 tasks

[2.x] Make the code stricter #30

devmoath opened this issue Nov 23, 2022 · 0 comments
Assignees
@devmoath
Labels
invalid This doesn't seem right wontfix This will not be worked on
Milestone
2.x

Comments

@devmoath
Copy link
Owner

devmoath commented Nov 23, 2022 •
edited

Things to do:

  • Remove spatie/macroable in favor of where closure
  • Drop PHP 8.0 support in favor of enums
  • Remove Laravel Facades support in favor of automatically resolving classes that do not have dependencies
  • Use phpstan/phpstan-strict-rules for stricter rules
  • Remove invalidBooleanOrOperator internal function
  • Use rector/rector for refactoring
  • Update test suite
  • Update README.md file
@devmoath devmoath added the feature New feature or request label Nov 23, 2022
@devmoath devmoath added this to the 2.x milestone Nov 23, 2022
@devmoath devmoath self-assigned this Nov 23, 2022
@devmoath devmoath added bug Something isn't working documentation Improvements or additions to documentation labels Nov 23, 2022
@devmoath devmoath removed bug Something isn't working documentation Improvements or additions to documentation labels Dec 9, 2022
@devmoath devmoath linked a pull request Dec 9, 2022 that will close this issue
[2x] make the code stricter #30 #33
Closed
@devmoath devmoath closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2022
Repository owner locked as resolved and limited conversation to collaborators Dec 30, 2022
@devmoath devmoath added invalid This doesn't seem right wontfix This will not be worked on and removed feature New feature or request labels Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devmoath devmoath

Labels
invalid This doesn't seem right wontfix This will not be worked on
Projects
None yet
Milestone
2.x
Development

Successfully merging a pull request may close this issue.

[2x] make the code stricter #30 devmoath/jql-builder
1 participant
@devmoath