Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies directions are found before stacks inference #146

Closed
grahamdyson opened this issue Aug 1, 2020 · 1 comment
Closed

dependencies directions are found before stacks inference #146

grahamdyson opened this issue Aug 1, 2020 · 1 comment
Labels

Comments

@grahamdyson
Copy link
Member

When stacks are inferred they can affect the direction of a dependency. Stack inference is implemented in JavaScript and can be run from the interactive web page when an analyzer isn't implemented in JavaScript (e.g. C#) . Dependency direction and mutual stacks are only found once to improve performance.

Currently stack inference in the interactive web page is running after dependency directions and mutual stacks are found which is displaying incorrect dependency counts and lists. Stack inference doesn't need dependency directions and mutual stacks so their execution could be swapped, displaying the correct dependency information without repeating the finding of dependency directions and mutual stacks.

@grahamdyson
Copy link
Member Author

released in C# 1.15.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant