Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown Element #379

Closed
e-roy opened this issue Aug 13, 2022 · 3 comments · Fixed by #395
Closed

Dropdown Element #379

e-roy opened this issue Aug 13, 2022 · 3 comments · Fixed by #395
Assignees
@Nazeeh21
Labels
help wanted Extra attention is needed

Comments

@e-roy
Copy link
Contributor

e-roy commented Aug 13, 2022

Currently we have a DropdownMenu element

This should be renamed to Dropdown

A lot will be removed from this element to get to the goal of a single element

The element should act similar to this tailwind dropdown component

props will include:

  • label?: string
  • placeholder?: string
  • items: string[]
  • onSelect?: (val: any) => void
@e-roy e-roy added the help wanted Extra attention is needed label Aug 13, 2022
@Nazeeh21
Copy link
Member

Can I work on this issue?

@e-roy
Copy link
Contributor Author

e-roy commented Aug 20, 2022

@Nazeeh21 you got it! :)

let me know if you have any issues or questions

@Nazeeh21
Copy link
Member

Sure thing

@Nazeeh21 Nazeeh21 mentioned this issue Aug 29, 2022
Merged
@e-roy e-roy closed this as completed in #395 Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nazeeh21 Nazeeh21

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/issue 379 Developer-DAO/web3-ui
2 participants
@Nazeeh21 @e-roy