-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Im implementing shop system and library too for players #25
Comments
You should raise a Pull Request to initiate discussion about your changes. |
Looks good 👍 |
i that system is not ready to PullRequest.. |
Here are some brief comments then:
|
Have any suggestions on how to get monsters data without accessing the XMLs all the time?
You right.i will fix that.
hmm.. ok make sense... it is about enhancer in frontend only... I have some questions about StatusMessage usage... how to make it work in any page without change all html files from modules. and how i can send a StatusMessage.. ( dont have much samples )
You right about that.. i will fix too. |
You can probably put that in APC (it's a soft dependency) or other cache. We should probably use laravel cache class. I might come up with something in future. In general, the database is definitely the worst place and parsing XML each time is also not a good idea as you said. |
Check my fork branch development.
Post your sugestions to my code style or something like..
( I need a feedback about licence and informations in header files )
https://github.com/novasdream/DevAAC
The text was updated successfully, but these errors were encountered: