Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should it be in buildModules and devDependency? #62

Closed
rchl opened this issue Sep 27, 2019 · 8 comments · Fixed by #84
Closed

Should it be in buildModules and devDependency? #62

rchl opened this issue Sep 27, 2019 · 8 comments · Fixed by #84

Comments

@rchl
Copy link

rchl commented Sep 27, 2019

Shouldn't documentation state that it should be added in buildModules (or devModules) rather than modules? And shouldn't it state that this is devDependency then? As far as I can see it only affects building.

@manniL
Copy link
Member

manniL commented Sep 27, 2019

It depends on how you handle devDeps and deps ☺️

Using it in buildModules instead of modules should be documented, sure.
I'd accept a PR there ☺️

@simllll
Copy link
Contributor

simllll commented Oct 2, 2019

We have it inside of buildModules and all works fine ;) (and therefore also listed as dev deps)

@rchl
Copy link
Author

rchl commented Oct 2, 2019

I'm not sure what you meant by this @manniL

It depends on how you handle devDeps and deps

@manniL
Copy link
Member

manniL commented Oct 8, 2019

@rchl

Some people use devDeps only for linters + testing utils and put "the rest" (so deps needed at build and at run time) in deps.

Others use devDeps for everything build-related and deps only for runtime builds.

@simplenotezy
Copy link

Would like to know how it can be used in devModules instead 😊 Currently added it to "modules", but not sure what the gains are of adding it to devModules

@curtisbelt
Copy link

@simplenotezy hey there, devModules is actually deprecated in favor of buildModules, and you can indeed add it there. The benefit is that buildModules are are not loaded in nuxt start.

@simplenotezy
Copy link

Thanks!

@manniL
Copy link
Member

manniL commented Apr 26, 2020

Will add that in the README. Thanks @rchl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants