Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

zenbot trade --strategy parameter not working #1177

Closed
kbfifi opened this issue Jan 19, 2018 · 2 comments
Closed

zenbot trade --strategy parameter not working #1177

kbfifi opened this issue Jan 19, 2018 · 2 comments
Labels

Comments

@kbfifi
Copy link

kbfifi commented Jan 19, 2018

System information

  • Have I written custom code (as opposed to using zenbot vanilla):
    No
  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
    Odroid C2, DietPi
  • Zenbot version:
    4.1.0
  • NodeJS version:
    8.4.0
  • Python version:
    2.7.9
  • Exact command to reproduce:
    In a separate config file I configured c.strategy = 'bollinger'
    Now I want to override that:
    zenbot trade --config <config.js file> --strategy trend_ema
    Result => bollinger is used. Strategy parameter is ignored.

Describe the problem

Describe the problem clearly here. Be sure to convey here why it's a bug in Zenbot or a feature request.
Bug: Parameter should override config file

Source code / logs

Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached. Try to provide a reproducible test case that is the bare minimum necessary to generate the problem.

@defkev
Copy link
Contributor

defkev commented Jan 19, 2018

Frankly this doesn't make sense in the first place.

Either use --conf (including the settings you want to override) or pass them as an argument.

@kbfifi
Copy link
Author

kbfifi commented Jan 20, 2018

At least I'd call it confusing. I can use:
./zenbot.sh trade gdax.ETH-EUR --paper --conf /root/zenbot/GDAX-ETH-EUR-trade/gdax-ETH-ETH-conf.js --period=2m --bollinger_upper_bound_pct=0 --bollinger_lower_bound_pct=0

So not consistent to allow for I guess most of parameters to be overuled and not --strategy.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants