Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

Question: why --start/end option are in timestamp and not in datetime ? #818

Closed
tfossoul opened this issue Dec 8, 2017 · 1 comment
Closed
Labels

Comments

@tfossoul
Copy link
Contributor

tfossoul commented Dec 8, 2017

It could be easier to launch sim with start/end as datetime format instead of timestamp format.
I can do the PR...
@@ -17,8 +17,8 @@ module.exports = function container (get, set, clear) {

-      .option('--start <timestamp>', 'start at timestamp')
-      .option('--end <timestamp>', 'end at timestamp')
+      .option('--start <datetime>', 'start ("YYYYMMDDhhmm")')
+      .option('--end <datetime>', 'end ("YYYYMMDDhhmm")')

@@ -49,13 +49,13 @@ module.exports = function container (get, set, clear) {

-          so.start = moment(so.start).valueOf()
+          so.start = moment(so.start, "YYYYMMDDhhmm").valueOf()

-          so.end = moment(so.end).valueOf()
+          so.end = moment(so.end, "YYYYMMDDhhmm").valueOf()
@DeviaVir
Copy link
Owner

Dear issue reporter,

We have slightly changed our github issue policy and would now kindly request folks that have questions that they ask them in our zenbot subreddit.

You can find it here: https://reddit.com/r/zenbot

This issue will be closed, but if you disagree with your ticket being marked as a question feel free to leave a comment defending your case.

Thanks for contributing time and effort!

Greetings,
🤖

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants