Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDM not seeing drop channels for Paladins #233

Closed
smallgarage opened this issue Jun 18, 2023 · 7 comments
Closed

TDM not seeing drop channels for Paladins #233

smallgarage opened this issue Jun 18, 2023 · 7 comments
Labels
Bug Something isn't working Solved This issue has been resolved

Comments

@smallgarage
Copy link

Hi, thanks so much for this great software. Have been using it for some time now, and it keeps getting better =)

I'm tried using the latest build from source (8189f01) since I noticed this begin happening while using another recent build. The miner isn't seeing any active drop channel for Paladins while there are definitely more than 1 active. Manually watching ttv/PaladinsGame in a browser does increase drop progress, and I see "Earned points for watching" messages in TDM related to that, along with "No available channels to watch. Waiting for an ONLINE channel...".

Recently I added a few more games to the mining list, but nothing else changed on my end.

Any ideas? Seems to only be affecting this game. It's also the only uncompleted campaign showing in the Inventory section.

@DovydasTEDS
Copy link

I have had the same, but with other vgames (I think all?)

@DevilXD
Copy link
Owner

DevilXD commented Jun 18, 2023

This kinda makes no sense what so ever, but I tried it anyway, and...

a7c3925 removes the "drops enabled" tag requirement from the channel search. The resulting list of channels appears to contain channels with the expected tag anyway.

Please try out the latest dev build to see if that works better.

@DevilXD DevilXD added the Bug Something isn't working label Jun 18, 2023
@smallgarage
Copy link
Author

It definitely wasn't making much sense. I'll try again when the new drop campaign starts later today and let you know. Thanks for the quick response & build!

Btw, I did notice that at least 1 of the active channels was using the tag "Drops Enabled" or "DropsEnabled" while this was happening.

@DevilXD
Copy link
Owner

DevilXD commented Jun 18, 2023

The tags you're seeing are "free form" tags. They have no actual tag ID associated to them, only the text string itself. They're completely unrelated of the actual "drops enabled" setting a streamer can set on their dashboard - one can enable drops but don't add any tags, or add a tag and don't enable the drops. Because of this, they cannot be relied upon, at all. Even if they could be considered as "a hint" of the tag being enabled, them being completely free form means the tag can come in many different languages, spellings, casings, and versions overall, making any system of searching for and filtering with the tag - impossible.

In other words, you can ignore whatever tags you see under the videos, the miner cannot use them in any useful way.

@smallgarage
Copy link
Author

Thanks for the explanation - that makes sense. It's unfortunate Twitch doesn't have a better system for this.

Happy to report that the new commit resolved the issue as well. Thank you again!

@DevilXD DevilXD added the Solved This issue has been resolved label Jun 19, 2023
@DevilXD
Copy link
Owner

DevilXD commented Jun 19, 2023

It's unfortunate Twitch doesn't have a better system for this.

The point is, they had a better system for this in the past, but decided to scrap it and replace it with those free form tags. This "process of scrapping" caused #189 and #212 to appear, both of which are now temp-fixed by ignoring the tag requirement when considering channels as mining candidates, and now fetching channels without the requirement of the tag being present.

In any way, I'm glad it's fixed for you now 🙂

@smallgarage
Copy link
Author

smallgarage commented Jun 22, 2023

I thought so! Interesting. And as of now there's no way for the API (or apparently the regular web users) to know whether the streamer has actually flipped the "drops on" toggle, other than watching the channel and seeing if drop progress happens? What a pain to develop workarounds for, aside from the regular client auth woes.

If that's all true I wonder what their motivations for making this change were. Perhaps complexities of certain drops only being for certain channels - it seems the miner is already somehow aware of this case, but maybe that's available from the drop campaign info.

Overall it seems to me that the system of drops being turned on to be the only way to have the visible "Drops Enabled" tag and a corresponding API value was pretty straightforward logic. Even if people could add custom tags like "Drops Here", etc. people would know to look for (and hopefully be able to search for) streams with the specific tag on, and could easily handle cases where the channel was online but not actively playing the game the drops is for, like "just chatting."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Solved This issue has been resolved
Projects
None yet
Development

No branches or pull requests

3 participants