Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move events from LavalinkPlayer to LavalinkManager #3

Closed
NovusTheory opened this issue Jun 1, 2018 · 0 comments
Closed

Move events from LavalinkPlayer to LavalinkManager #3

NovusTheory opened this issue Jun 1, 2018 · 0 comments
Assignees
@NovusTheory
Labels
enhancement New feature or request

Comments

@NovusTheory
Copy link
Collaborator

Events can get really messy and just managing the players in general, especially from re-evaluating the code that it would produce it's quite ugly and wouldn't be that good. We'll instead move all the player events from the LavalinkPlayer to the LavalinkManager and pass the LavalinkPlayer for whom the event belongs to
@NovusTheory NovusTheory added the enhancement New feature or request label Jun 1, 2018
@NovusTheory NovusTheory self-assigned this Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NovusTheory NovusTheory

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NovusTheory