Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make virtual grid keys mappable with the VCV MIDI Map module #83

Closed
Dewb opened this issue Dec 19, 2021 · 1 comment
Closed

Make virtual grid keys mappable with the VCV MIDI Map module #83

Dewb opened this issue Dec 19, 2021 · 1 comment

Comments

@Dewb
Copy link
Owner

Dewb commented Dec 19, 2021

Issues preventing MIDI Map support:

  1. Both serialization and mappability are controlled by whether the param is bounded, so there is no obvious way to make a param mappable but not serialized.
  2. Mapping a button with a 0-127 CC prevents that button from being used interactively; the 0 value from MIDI Map always overwrites the interactive control.
  3. Not clear how pressed/held states work with mapping.

1 and 3 are probably resolvable by just allowing the params to be serialized, and removing the distinction between press and hold in param state. Hold can be implemented by just ignoring mouseup, it doesn't need to be a separate state.

Issue 2 can probably be resolved by keeping two sets of Rack parameter values, one for mapping, one for interactive control, and sending grid key presses when either one or the other is high.

@Dewb
Copy link
Owner Author

Dewb commented Dec 20, 2021

Fixed in e99cc69.

@Dewb Dewb closed this as completed Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 2.0.0-alpha5 (2021-12-19)
Development

No branches or pull requests

1 participant