Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Structuring #147

Merged
merged 5 commits into from
Sep 28, 2017
Merged

Re-Structuring #147

merged 5 commits into from
Sep 28, 2017

Conversation

KaiSchwarz-cnic
Copy link
Contributor

moved openssl logic in its own separate file. accessible via openssl.exec(), openssl.execBinary(), openssl.spawn() and openssl.spawnWrapper() when having lib/openssl.js added via require.

Configuration options gone also this way e.g.:

openssl.set(key, value);
openssl.get(key);

//e.g.
openssl.set('pathOpenSSL', '.....');
openssl.get('pathOpenSSL');
openssl.get('openSslVersion');

@Dexus
Copy link
Owner

Dexus commented Sep 28, 2017

@Papakai can you also remove the console.log as reported in #146 thank

@KaiSchwarz-cnic
Copy link
Contributor Author

@Dexus I am not able to find this console.log in checkPkcs12, maybe it got already removed.

@Dexus
Copy link
Owner

Dexus commented Sep 28, 2017

Yeah think, I may have done it already in the devel branch... but not in master

@Dexus Dexus merged commit becf9df into devel Sep 28, 2017
@Dexus Dexus deleted the structuring branch September 28, 2017 17:51
Dexus pushed a commit that referenced this pull request Sep 29, 2017
* move openssl part in its own file

* reviewed jsdoc comments

* reviewed timeout settings

* review set method (remove whitelisting)

* adding todo comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants