-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completed tasks dont stay completed #4
Comments
Yeah, you can store every task as an object so the checked one stay checked even after refreshing the page. |
@Dharmik48 There is also a security bug to html / js injection. Inserting |
I think its because we are setting the new todo with the |
Yep, exactly. We'd need to change the logic to creating the element then setting the innerText to the input. I've raised a separate Issue for that |
Yes, I saw your issue. Are you willing to work on that? |
@Dharmik48 Can we close this issue now its been closed by #8 |
Yeah, I forgot to close this😅 |
Closed with #8 |
Since the PR was merged to save the tasks to local storage the tasks are saved but not their state(completed or not)
The local storage will need to be refreshed to store the tasks as objects.
e.g.[ {title: 'task 1', completed: true} ]
The text was updated successfully, but these errors were encountered: