Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for command FILTERKEYS #35

Open
arpitbbhayani opened this issue Oct 18, 2022 · 9 comments · May be fixed by #84
Open

Add support for command FILTERKEYS #35

arpitbbhayani opened this issue Oct 18, 2022 · 9 comments · May be fixed by #84
Assignees
@MayukhSobo
Labels
new -- command

Comments

@arpitbbhayani
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We need a way to filter out keys on the basis of wildcard patterns; so that the KV tuples can be piped through other commands for in-mem aggregations.

Describe the solution you'd like
Create a command FILTERKEYS that accepts wildcards as an argument and returns the list of KV pairs as a response.

> FILTERKEYS "*user:*"
0) 0) user:1
    1) value:1
1) 0) user:2
    1) value:2

a JSON equivalent of the response is

[
    ["user:1", "value:1"],
    ["user:2", "value:2"],
    ...
]
@MayukhSobo
Copy link

Hi @arpitbbhayani. Can I take this up? This would be my first encounter with DiceDB

@arpitbbhayani
Copy link
Contributor Author

@MayukhSobo go for it. Assigning it to you.

@arpitbbhayani
Copy link
Contributor Author

@MayukhSobo where are you with the implementation? are you stuck somewhere? You can join the Discord Server for quick collaboration.

@MayukhSobo
Copy link

@arpitbbhayani I am almost done with the changes. However to implement something, I needed to make a lot of changes. I would explain more in the PR. Give me 2 more days.

@arpitbbhayani
Copy link
Contributor Author

@MayukhSobo sure. No worries take your time 🙌

@MayukhSobo
Copy link

@arpitbbhayani Is there any DO_NOT_MERGE tag so that I can raise the PR already and you can see the changes?

@arpitbbhayani
Copy link
Contributor Author

@MayukhSobo that is totally fine. Folks would not automatically merge.

@Prady2006
Copy link

Hey @MayukhSobo are you still working on the feature , or can i start working on this feature @arpitbbhayani ?

@MayukhSobo
Copy link

@Prady2006 I am working on this. Will make a PR today.

@MayukhSobo MayukhSobo linked a pull request Nov 2, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MayukhSobo MayukhSobo

Labels
new -- command
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

35 Added the support for FILTERKEYS MayukhSobo/dice
3 participants
@arpitbbhayani @MayukhSobo @Prady2006