Skip to content

Commit

Permalink
Merge pull request #46 from devgateway/propagate-change-event
Browse files Browse the repository at this point in the history 
propagate change event to onChange callback
  • Loading branch information
@DennisSuitters
DennisSuitters committed Feb 17, 2018
2 parents 0b8564e + 74d07ce commit 1f91072
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions summernote-image-attributes.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,8 @@
linkStyle: $linkStyle.val(),
linkRel: $linkRel.val(),
linkRole: $linkRole.val()
}).then((img) => {
context.triggerEvent('change', $editable.html());
});
});
$imageTitle.val(imgInfo.title);
Expand Down

2 comments on commit 1f91072

@tlartaud
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @diemendesign

This commit leads to Uglify compilation error. Could you fix the syntax, please?

Running "uglify:libs-assets" (uglify) task
{ SyntaxError: Unexpected token: operator (>)
  at JS_Parse_Error.get (<anonymous>:75:23)
  at formatError (util.js:659:16)
  at formatValue (util.js:532:17)
  at inspect (util.js:307:10)
  at format (util.js:169:12)
  at Console.log (console.js:133:21)
  at C:\Users\conta\Projets\customer-area\build-environment\node_modules\grunt-contrib-uglify\tasks\uglify.js:144:17
  at Array.forEach (<anonymous>:null:null)
  at Object.<anonymous> (C:\Users\conta\Projets\customer-area\build-environment\node_modules\grunt-contrib-uglify\tasks\uglify.js:78:16)
  at Object.<anonymous> (C:\Users\conta\Projets\customer-area\build-environment\node_modules\grunt\lib\grunt\task.js:252:15)
  at Object.thisTask.fn (C:\Users\conta\Projets\customer-area\build-environment\node_modules\grunt\lib\grunt\task.js:70:16)
  at Object.fn (C:\Users\conta\Projets\customer-area\build-environment\node_modules\jit-grunt\lib\jit-grunt.js:126:30)
  at Object.<anonymous> (C:\Users\conta\Projets\customer-area\build-environment\node_modules\grunt\lib\util\task.js:294:30)
  at Task.runTaskFn (C:\Users\conta\Projets\customer-area\build-environment\node_modules\grunt\lib\util\task.js:244:24)
  at Task.<anonymous> (C:\Users\conta\Projets\customer-area\build-environment\node_modules\grunt\lib\util\task.js:293:12)
  at C:\Users\conta\Projets\customer-area\build-environment\node_modules\grunt\lib\util\task.js:220:11
  at process._tickCallback (internal/process/next_tick.js:176:11)

  message: 'Unexpected token: operator (>)',
  filename: '../../../../node_modules/summernote-image-attributes/summernote-image-attributes.js',
  line: 343,
  col: 29,
  pos: 20222 }
>> Uglifying source wp-plugins/customer-area/node_modules/summernote-image-attributes/summernote-image-attributes.js,wp-plugins/customer-area/node_modules/summernote-image-attributes/lang/de-DE.js,wp-plugins/customer-area/node_modules/summernote-image-
attributes/lang/es-ES.js,wp-plugins/customer-area/node_modules/summernote-image-attributes/lang/fr-FR.js,wp-plugins/customer-area/node_modules/summernote-image-attributes/lang/it-IT.js,wp-plugins/customer-area/node_modules/summernote-image-attributes/l
ang/pt-BR.js,wp-plugins/customer-area/node_modules/summernote-image-attributes/lang/ru-RU.js,wp-plugins/customer-area/node_modules/summernote-image-attributes/lang/tr-TR.js,wp-plugins/customer-area/node_modules/summernote-image-attributes/lang/zh-TW.js
 failed.
Warning: Uglification failed.
Unexpected token: operator (>). 
Line 343 in wp-plugins/customer-area/node_modules/summernote-image-attributes/summernote-image-attributes.js,wp-plugins/customer-area/node_modules/summernote-image-attributes/lang/de-DE.js,wp-plugins/customer-area/node_modules/summernote-image-attribut
es/lang/es-ES.js,wp-plugins/customer-area/node_modules/summernote-image-attributes/lang/fr-FR.js,wp-plugins/customer-area/node_modules/summernote-image-attributes/lang/it-IT.js,wp-plugins/customer-area/node_modules/summernote-image-attributes/lang/pt-B
R.js,wp-plugins/customer-area/node_modules/summernote-image-attributes/lang/ru-RU.js,wp-plugins/customer-area/node_modules/summernote-image-attributes/lang/tr-TR.js,wp-plugins/customer-area/node_modules/summernote-image-attributes/lang/zh-TW.js
 Use --force to continue.

Aborted due to warnings.

Regards.

@DennisSuitters
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why Github didn't notify me of this, bit weird.
I'll have a look.

Please sign in to comment.