Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make configobj a package, moving towards incorporating validate #85

Merged
merged 4 commits into from May 1, 2015
Merged

Make configobj a package, moving towards incorporating validate #85

merged 4 commits into from May 1, 2015

Conversation

jhermann
Copy link
Collaborator

I'm opening this PR early for review and commenting, this is intended to handle #32 and associated tickets. Will comment when things are ready for a merge.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.97% when pulling ffd220a on jhermann:move-to-package-32 into 0daebcb on DiffSK:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.97% when pulling ffd220a on jhermann:move-to-package-32 into 0daebcb on DiffSK:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.97% when pulling ffd220a on jhermann:move-to-package-32 into 0daebcb on DiffSK:master.

@jhermann
Move modules towards a 'configobj' package
0cfca0c 
* handles DiffSK#72
* handles DiffSK#31
* handles the core of DiffSK#32
* using ImportWarning as appropriate for an import change
* tox passing for py27, i.e. structurally sound
* the shim should probably released one final time as
  'validate' to PyPI
@coveralls
Copy link

Coverage Status

Coverage increased (+22.03%) to 100.0% when pulling 0cfca0c on jhermann:move-to-package-32 into 0daebcb on DiffSK:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+22.03%) to 100.0% when pulling 0cfca0c on jhermann:move-to-package-32 into 0daebcb on DiffSK:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+22.03%) to 100.0% when pulling 088b296 on jhermann:move-to-package-32 into 0daebcb on DiffSK:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+22.03%) to 100.0% when pulling 088b296 on jhermann:move-to-package-32 into 0daebcb on DiffSK:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.41%) to 77.56% when pulling e88c7d2 on jhermann:move-to-package-32 into 0daebcb on DiffSK:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.41%) to 77.56% when pulling e88c7d2 on jhermann:move-to-package-32 into 0daebcb on DiffSK:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.41%) to 77.56% when pulling e88c7d2 on jhermann:move-to-package-32 into 0daebcb on DiffSK:master.

@jhermann
Copy link
Collaborator Author

This is, for the moment, complete. Further steps like splitting __init__ into smaller portions should be done outside this PR.

@EliAndrewC
Copy link
Member

Looks pretty great; I left a comment on the linked ticket, but I expect to be able to merge this in later this week after I have a chance to give it a little more scrutiny just to be safe. Thanks!

EliAndrewC added a commit that referenced this pull request May 1, 2015
@EliAndrewC
Merge pull request #85 from jhermann/move-to-package-32
a68530a 
Make configobj a package, moving towards incorporating validate
@EliAndrewC EliAndrewC merged commit a68530a into DiffSK:master May 1, 2015
@EliAndrewC
Copy link
Member

Just merged this in - thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jhermann @coveralls @EliAndrewC