Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the macro-generated static #18

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Conversation

FlixCoder
Copy link
Contributor

#[warn(missing_docs)] complains about the generated static as it misses documentation. This should fix it.

Feel free the change the actual documentation.

@Diggsey
Copy link
Owner

Diggsey commented Jan 12, 2022

Thanks for the PR! I think I'd prefer to move any #[doc] attribute from the function to the static as part of the macro expansion though, rather then generating our own less useful documentation.

@FlixCoder
Copy link
Contributor Author

Now it is copy rather than move, but I changed it to user-defined documentation attributes.

Also there was one clippy warning I fixed ^^

sqlxmq_macros/src/lib.rs Outdated Show resolved Hide resolved
`#[warn(missing_docs)]` complains about the generated static as it misses documentation. This keeps the documentation both in front of the static and inside.
@Diggsey Diggsey merged commit 6d3ed6f into Diggsey:master Jan 13, 2022
@FlixCoder
Copy link
Contributor Author

Thanks! If possible, could I ask for a minor release for it? :)

@FlixCoder FlixCoder deleted the patch-1 branch January 14, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants