Skip to content

Commit

Permalink
Bump php version
Browse files Browse the repository at this point in the history
  • Loading branch information
DigiLive committed Oct 21, 2020
1 parent 0c01c71 commit 101b8fa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion composer.json
View file
Expand Up @@ -22,7 +22,7 @@
}
],
"require": {
"php": "^7.2"
"php": "^7.3"
},
"require-dev": {
"phpunit/phpunit": "^9",
Expand Down

4 comments on commit 101b8fa

@JBlond
Copy link
Collaborator

@JBlond JBlond commented on 101b8fa Oct 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well jblond/php-diff still uses PHP 7.2 and phpunit 8

@JBlond
Copy link
Collaborator

@JBlond JBlond commented on 101b8fa Oct 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we could change that to 7.3 since support for 7.2 is almost over. https://www.php.net/supported-versions.php

@DigiLive
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was doubting about bumping to 7.3.
For the same reason and the use of PHPUnit v9, the version was bumped.

However the market share of php 7.2 (32%) is larger than 7.3 (28.1%), according to https://w3techs.com/technologies/details/pl-php/7
Let give it a thought which would be the better option... Bump php-diff to 7.3 or lower gitChangeLog to 7.2?

@DigiLive
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created issue #4 for these comments.

Please sign in to comment.