Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct access to neoscore.background_brush #114

Open
ajyoon opened this issue Feb 16, 2024 · 0 comments
Open

Remove direct access to neoscore.background_brush #114

ajyoon opened this issue Feb 16, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ajyoon
Copy link
Collaborator

ajyoon commented Feb 16, 2024

neoscore.background_brush is a global variable that users are expected to set using neoscore.set_background_brush, but this creates a very easy error for users understandably attempting to change the background brush by simply saying neoscore.background_brush = Brush(...).

We should update this to make the global variable hidden by naming it neoscore._background_brush, and then making access to it go through a new function neoscore.get_background_brush() -> Brush.

This is a breaking change, but I think worthwhile. The background brush is very rarely read by users anyway.

@ajyoon ajyoon added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant