Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project-Create - Get user from httpcontext #139

Closed
Brend-Smits opened this issue May 21, 2020 · 0 comments · Fixed by #144
Closed

Project-Create - Get user from httpcontext #139

Brend-Smits opened this issue May 21, 2020 · 0 comments · Fixed by #144
Assignees
@wotwot563
Labels
bug Something isn't working priority Only assign this label if it's asked to assign this label requires development
Projects
Sprint 4 - Backend

Comments

@Brend-Smits
Copy link
Member

Describe the bug
When creating a project in the Frontend, we do not send the user id. Leading to bad requests since no user can be coupled to the project. The same goes for the Postman tests that I'm setting up with ACL now.

Expected behavior
In the backend we should retrieve the user id from the HttpContext instead. We should add an extension method that can be called when this is needed, I suspect more endpoints needing this in the future.
We should also remove the user id from the resource altogether since we do not want people impersonating others when making a request.
@Brend-Smits Brend-Smits added bug Something isn't working requires development priority Only assign this label if it's asked to assign this label labels May 21, 2020
@Brend-Smits Brend-Smits mentioned this issue May 21, 2020
Closed
@wotwot563 wotwot563 self-assigned this May 21, 2020
@wotwot563 wotwot563 mentioned this issue May 21, 2020
Merged
12 tasks
@wotwot563 wotwot563 moved this from To do to Review in progress in Sprint 4 - Backend May 21, 2020
Sprint 4 - Backend automation moved this from Review in progress to Done May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wotwot563 wotwot563

Labels
bug Something isn't working priority Only assign this label if it's asked to assign this label requires development
Projects
No open projects
Sprint 4 - Backend
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/139 get user from httpcontext DigitalExcellence/dex-backend
2 participants
@Brend-Smits @wotwot563