Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The get highlights endpoint returns too much information #205

Closed
StijnGroenen opened this issue Jun 18, 2020 · 1 comment · Fixed by #252
Closed

The get highlights endpoint returns too much information #205

StijnGroenen opened this issue Jun 18, 2020 · 1 comment · Fixed by #252
Assignees
Labels
bug Something isn't working Good first issue Good first issue to get to know the project internally.

Comments

@StijnGroenen
Copy link
Member

Describe the bug
The HighlightResourceResult class returns the full project model instead of using a resource class. It also includes the start and end date of the highlight. In my opinion, these dates should not be returned (unless we actually want to show them in the front end).

To Reproduce
Make a request to the get highlights endpoint.
The start and end dates are returned as well as the full project model.

Expected behaviour
The start and end dates should not be returned.
The only project information that should be returned is the information that is actually shown on the highlights page (homepage) in the front end. Like the name and the short description.

@StijnGroenen StijnGroenen added the bug Something isn't working label Jun 18, 2020
@StijnGroenen StijnGroenen added this to To do in Beta Release via automation Jun 18, 2020
@Brend-Smits Brend-Smits added the Good first issue Good first issue to get to know the project internally. label Sep 15, 2020
@Brend-Smits Brend-Smits added this to To do in Sprint 5 - Backend via automation Sep 15, 2020
@Brend-Smits
Copy link
Member

With the addition of #218 we only need to return the project id, highlight id, and description I think.

@niraymak niraymak self-assigned this Oct 1, 2020
@Brend-Smits Brend-Smits moved this from To do to In progress in Sprint 5 - Backend Oct 2, 2020
Sprint 5 - Backend automation moved this from In progress to Done Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Good first issue Good first issue to get to know the project internally.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants