Bug: Inefficient use of entity framework in GetAllWithUsersAndCollaboratorsAsync() (in the ProjectRepository)

[TimSnoek123]

Describe the bug
The function GetAllWithUsersAndCollaboratorsAsync() in the ProjectRepository implements a really inefficient way of getting data. This should be improved by using .include(). With 5000 projects using .include() takes around 300 ms and the current way of getting the data takes around 1900 ms. (and even with less data it is around 70% faster)

Screenshots

As you can see above for every project 2 additional queries are called in order to get the collaborators and the likes. Using include only executes one query which is way faster especially when getting lots of data.

[Brend-Smits]

This is very strange. The results I got when testing this were the other way around. Are you sure the data set that you tested with includes likes and collaborators?
See: #335

[TimSnoek123]

The data did have collaborators but not likes, I will try testing it again tomorrow I guess with more relational data.

[Brend-Smits]

The data did have collaborators but not likes, I will try testing it again tomorrow I guess with more relational data.

Still, the results should be the other way around... unless something has changed in terms of packages that got updated to fix this issue.
How many collaborators were included per project? (Average)

[TimSnoek123]

I just created 5000 projects each with: 7 collaborators and one like.

The include took around: 7 seconds.
The old version took around: 23 seconds.

[Brend-Smits]

Well, that sounds good then! I'm glad to hear the issue is resolved. Nice😀

[TimSnoek123]

Yes! Maybe Microsoft updated EF or something ¯_(ツ)_/¯

[RamonPeek]

Just validated the behaviour on my machine. Old code takes about 70ms to execute for 30 projects (with collaborators), and the improved code takes about 15 to 20 ms. I also included the likes and Redacted user, so only one SQL query has to be executed each time the projects are retrieved. This second include takes another 3 to 5ms from the response time.

I'll push the changes and open a PR for it.