Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fontys' Gitlab data source to the wizard #377

Closed
RubenFricke opened this issue Feb 23, 2021 · 4 comments · Fixed by #462
Closed

Add Fontys' Gitlab data source to the wizard #377

RubenFricke opened this issue Feb 23, 2021 · 4 comments · Fixed by #462
Assignees
@TimSnoek123
Labels
requires development Wizard Issues marked with this label are related to the wizard
Projects
Sprint 10 - Backend Sprint 11 - Backend

Comments

@RubenFricke
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently the implementation of the wizard supports 3 data sources (Github, Gitlab and JsFiddle). Gitlab only supports main Gitlab and not the Fontys Gitlab variant. This data source should be added.

Update the wizard so that Fontys' Gitlab gets supported as well. When creating support for this, it's important to keep programming principles in your mind (DRY, but also SOLID, KISS, etc.). Don't Repeat Yourself. All the logic for the main Gitlab data source is already written. Research if the logic that's already written can get reused.

Describe the solution you'd like

Additional context
@RubenFricke RubenFricke added requires development Planned Feature is planned for a future release Wizard Issues marked with this label are related to the wizard and removed Planned Feature is planned for a future release labels Feb 23, 2021
@RubenFricke RubenFricke changed the title [NEEDS MORE INFORMATION] Add Fontys' Gitlab data source to the wizard Add Fontys' Gitlab data source to the wizard Feb 23, 2021
@TimSnoek123 TimSnoek123 self-assigned this Mar 23, 2021
@TimSnoek123 TimSnoek123 added this to To do in Sprint 9 - Backend via automation Mar 23, 2021
@niraymak niraymak removed this from To do in Sprint 9 - Backend Mar 23, 2021
@niraymak niraymak added this to To do in Sprint 10 - Backend via automation Mar 23, 2021
@TimSnoek123 TimSnoek123 moved this from To do to In progress in Sprint 10 - Backend Mar 24, 2021
@TimSnoek123
Copy link
Contributor

Kwa code hoeft er weinig aangemaakt te worden want de gitlab datasource class kan gewoon geinherit worden. Ik heb nu aan Marcel Narings gevraagd voor gitlab api credentials.

@RubenFricke
Copy link
Member Author

@TimSnoek123 Try to avoid dutch 😉 . An English student will join our project and he has to be able to understand the comments on all the issues.

Tim says: We don't have to create a lot of new code because the original GitLab data source can get inherited. He requested the FHICT GitLab API credentials by Marcel Narings.

@TimSnoek123
Copy link
Contributor

I created a dex account to test the gitlab functionality. The Get all projects from a specific user seems to be working.

Getting a project by a specific endpoint returns 404 not found when you are not logged in as a user as you can see here. If you log into the fhict gitlab the project becomes visible.

Getting a project by a specific id returns some weird JSON where the description is the login page of FHICT?
{ "id": 19845, "name": "Gamehub-Client", "description": " <!DOCTYPE html>\r\n<html lang=\"en-US\">\r\n <head>\r\n <meta http-equiv=\"X-UA-Compatible\" content=\"IE=edge\"/>\r\n <meta name=\"viewport\" content=\"width=device-width, initial-scale=1.0, user-scalable=1\"/>\r\n <meta http-equiv=\"content-type\" content=\"text/html;charset=UTF-8\" />\r\n <meta http-equiv=\"cache-control\" content=\"no-cache,no-store\"/>\r\n <meta http-equiv=\"pragma\" content=\"no-cache\"/>\r\n <meta http-equiv=\"expires\" content=\"-1\"/>\r\n <meta name='mswebdialog-title' content='Connecting to Fontys Hogeschool ICT'/>\r\n\r\n <title>Sign In</title>\r\n <script type='text/javascript'>\r\n//<![CDATA[\r\nfunction LoginErrors(){this.userNameFormatError = 'Enter your user ID in the format \\u0026quot;domain\\\\user\\u0026quot; or \\u0026quot;user@domain\\u0026quot;.'; this.passwordEmpty = 'Enter your password.'; this.passwordTooLong = 'Password is too long (\\u0026gt; 128 characters).';}; var maxPasswordLength = 128;\r\n//]]>\r\n</script>\r\n\r\n<script.....", "shortDescription": "", "uri": null, "collaborators": [], "projectIcon": null }

@TimSnoek123
Copy link
Contributor

The login before you can get the data also applies for that weird JSON.

@niraymak niraymak added this to To do in Sprint 11 - Backend via automation Apr 8, 2021
@niraymak niraymak moved this from To do to In progress in Sprint 11 - Backend Apr 8, 2021
@niraymak niraymak added this to To do in Sprint 12 - Backend via automation May 10, 2021
@niraymak niraymak moved this from To do to In progress in Sprint 12 - Backend May 10, 2021
@niraymak niraymak removed this from In progress in Sprint 12 - Backend Jun 7, 2021
@TimSnoek123 TimSnoek123 mentioned this issue Jun 17, 2021
Merged
13 tasks
Sprint 10 - Backend automation moved this from In progress to Done Jun 28, 2021
Sprint 11 - Backend automation moved this from In progress to Done Jun 28, 2021
@niraymak niraymak mentioned this issue Jun 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimSnoek123 TimSnoek123

Labels
requires development Wizard Issues marked with this label are related to the wizard
Projects
Sprint 10 - Backend
Done
Sprint 11 - Backend
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/377 fontys gitlab datasource to wizard DigitalExcellence/dex-backend
2 participants
@TimSnoek123 @RubenFricke