Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get All Projects performance #436

Closed
TimSnoek123 opened this issue May 6, 2021 · 3 comments · Fixed by #437 or #439
Closed

Get All Projects performance #436

TimSnoek123 opened this issue May 6, 2021 · 3 comments · Fixed by #437 or #439
Assignees
@TimSnoek123
Labels
bug Something isn't working
Projects
Sprint 12 - Backend

Comments

@TimSnoek123
Copy link
Contributor

The current GetAllWithUsersCollaboratorsAndInstitutionsAsync which gets the projects for the projects page is really inefficient the query gets data 2 times while include already gets the data in the first .ToListAsync(). Furthermore the ToListAsync() gets called twice for some reason?

image
@TimSnoek123 TimSnoek123 added the bug Something isn't working label May 6, 2021
@TimSnoek123
Copy link
Contributor Author

The Load() is also quite weird, so I think its pretty easy to quickly optimize this function a bit more

@TimSnoek123 TimSnoek123 mentioned this issue May 6, 2021
Merged
13 tasks
@TimSnoek123 TimSnoek123 self-assigned this May 6, 2021
@TimSnoek123 TimSnoek123 added this to To do in Sprint 11 - Backend via automation May 6, 2021
@TimSnoek123 TimSnoek123 moved this from To do to Review in progress in Sprint 11 - Backend May 6, 2021
@TimSnoek123
Copy link
Contributor Author

Put it sprint 11 for now, since I can't find sprint 12.

Sprint 11 - Backend automation moved this from Review in progress to Done May 18, 2021
@niraymak niraymak reopened this May 19, 2021
Sprint 11 - Backend automation moved this from Done to In progress May 19, 2021
@TimSnoek123 TimSnoek123 removed this from In progress in Sprint 11 - Backend May 19, 2021
@TimSnoek123 TimSnoek123 added this to To do in Sprint 12 - Backend via automation May 19, 2021
@TimSnoek123 TimSnoek123 moved this from To do to In progress in Sprint 12 - Backend May 19, 2021
@TimSnoek123 TimSnoek123 mentioned this issue May 19, 2021
Merged
13 tasks
@niraymak
Copy link
Member

Performance is better after merging this PR, however with "awesome dot net" it is for some reason on the servers slower. Local debugging is also faster with awesome dot which is weird.

We now will try to not retrieve the long description from the database.

Sprint 12 - Backend automation moved this from In progress to Done May 26, 2021
@niraymak niraymak mentioned this issue Jun 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimSnoek123 TimSnoek123

Labels
bug Something isn't working
Projects
Sprint 12 - Backend
Done
Milestone
No milestone
2 participants
@niraymak @TimSnoek123