Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spouts : load results with a non-blocking call #371

Closed
jnioche opened this issue Nov 1, 2016 · 2 comments
Closed

Spouts : load results with a non-blocking call #371

jnioche opened this issue Nov 1, 2016 · 2 comments
Assignees
Milestone

Comments

@jnioche
Copy link
Contributor

jnioche commented Nov 1, 2016

We currently block the nextTuple when executing an Elasticsearch query and as such prevent ack/fails to happen. Instead, we should execute the ES query with a non-blocking call and return as soon as possible. This would possibly require the access to the buffer to be synchronized and an additional check that we are not already querying.

@jnioche jnioche added this to the 1.3 milestone Nov 1, 2016
@jnioche jnioche self-assigned this Nov 1, 2016
@jnioche jnioche changed the title Spouts : loads results with a non-blocking call Spouts : load results with a non-blocking call Nov 1, 2016
@XciD
Copy link
Contributor

XciD commented Nov 14, 2016

I've done something similar on my spouts, as you say, in order to don't block nextTuple, ackand fail methods

I will try to generify

@jnioche
Copy link
Contributor Author

jnioche commented Nov 14, 2016

That would be great. Thanks

On 14 Nov 2016 11:38, "XciD" notifications@github.com wrote:

I've done something similar on my spouts, as you say, in order to don't
block nextTuple, ackand fail methods

I will try to generify


You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#371 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AANUz7pU-_2mAVPigeaOOUHpliAaz7o2ks5q-DoZgaJpZM4KmIPs
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants