Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdaptiveScheduler to set last-modified time in metadata, fixes #777 #812

Merged
merged 1 commit into from Jul 8, 2020

Conversation

sebastian-nagel
Copy link
Contributor

  • this PR assumes that the HTTP last-modified field is kept separately, see protocol.md.prefix and Prefix protocol metadata to avoid that internal metadata fields are accidentally overwritten #776
  • set last-modified in metadata
    • for the initial successful fetch (also after error status)
    • and if a change of the content signature indicates a modification
  • clear last-modified for permanent failures (status ERROR)
  • set fetchInterval in metadata for initial fetches scheduled by DefaultScheduler

…#777

- assumed that the HTTP last-modified field is kept separately,
  see `protocol.md.prefix` and apache#776
- set `last-modified` in metadata
  - for the initial successful fetch (also after error status)
  - and if a change of the content signature indicates a modification
- clear `last-modified` for permanent failures (status ERROR)
- set `fetchInterval` in metadata for initial fetches scheduled
  by DefaultScheduler
@jnioche jnioche added the core label Jul 8, 2020
@jnioche jnioche added this to the 1.17 milestone Jul 8, 2020
@jnioche jnioche merged commit 3475236 into apache:master Jul 8, 2020
@jnioche
Copy link
Contributor

jnioche commented Jul 8, 2020

brilliant, thanks @sebastian-nagel

@sebastian-nagel
Copy link
Contributor Author

I'll also update the wiki, later today or tomorrow.

@sebastian-nagel sebastian-nagel deleted the sc-777-last-modified branch October 11, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

status index / Adaptive scheduler: get rid of last-modified dates in non-ISO date format
2 participants