Change HttpProtocol to defer to configured values for retryOnConnectionFailure and followRedirects #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nathan <nathan@cameraforensics.com>
…ault conf for documentation Signed-off-by: nathan <nathan@cameraforensics.com>
Signed-off-by: nathan <nathan@cameraforensics.com>
ndtreviv
force-pushed
the
allow-redirect-config
branch
from
ac4310a
to
ed2a231
Compare
rzo1
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this version we defer to the configuration for the okhttp client settings on:
The rationale behind this is that a lot of sites are increasingly introducing DDos protection strategies and bot checks. For example, DDos Guard is a popular one. One such check is the "HTTP Challenge" which issues a simple 302 response to the first request. If the requestor is a bot engaged in denial of service activities it is expected to just ignore it and end another request.
Simply by following redirects we can overcome this.
Disclaimer: I haven't squashed my commits because you can do that on merge these days, which is much easier.