Cache redirected robots.txt for target host only if path is /robots.txt and query is empty #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URL path including the query part is `/robots.txt` Signed-off-by: Sebastian Nagel <sebastian@commoncrawl.org>
|
thanks @sebastian-nagel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get/put redirected robots.txt from/to cache of target host only if the URL path including the query part is
/robots.txt. The current code does not take the URL query part into consideration. In some (likely rare) cases, this may cause that the wrong robots.txt, e.g./robots.txt?from=source.example.comis cached.Note: the host port (and protocol) are part of the cache key. If the redirect leads to a different port on the target host, the robots.txt received from a request on this port is cached separately.