Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpProtocol use the md protocol.set-headers to add custom header by url #993

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

Mikwiss
Copy link
Contributor

@Mikwiss Mikwiss commented Jul 27, 2022

Hi @jnioche !

We need to provide some headers at the request level (instead of the topology level). The protocols are now able to add some headers specified in metadata.

To complete the documentation : https://github.com/DigitalPebble/storm-crawler/wiki/HTTPProtocol

protocol.set-headers: If this key is present in metadata, the protocol add the specified headers to the request.
Md example :
"protocol%2Eset-header": [
"header1=value1",
"header2=value2"
]

Signed-off-by: Mathieu Bret mikwiss00@gmail.com

Thanks for contributing to StormCrawler, your efforts are appreciated!

Developer Certificate of Origin

By contributing to StormCrawler, you accept and agree to the following terms and conditions (the Developer Certificate of Origin) for your present and future contributions submitted to StormCrawler.
Please refer to the Developer Certificate of Origin section in CONTRIBUTING.md for details.

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Before opening a PR, please check that:

  • You've squashed your commits into a single one
  • You've described what the PR does or at least point to a related issue
  • You've signed-ff your commits with 'git commit -s'
  • The code is properly formatted with 'mvn git-code-format:format-code -Dgcf.globPattern=**/*'

Thanks!

Signed-off-by: Mathieu Bret <mikwiss00@gmail.com>
@jnioche jnioche added this to the 2.5 milestone Jul 27, 2022
@jnioche jnioche merged commit 3f05d46 into apache:master Jul 27, 2022
@jnioche
Copy link
Contributor

jnioche commented Jul 27, 2022

thanks @Mikwiss, this is a great contribution. Will update the WIKI

@Mikwiss Mikwiss deleted the protocol-set-headers branch October 19, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants