Recognize binary vector files without line breaks #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function to load binary word vector files did assume newlines before each (name, word vector) pair. The Google News Corpus doesn't have these and hence it failed to load the file. Gensim simply assumes no newlines and strips them, if it they occur. This crate now does the same.
|
Merged and updated library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function to load binary word vector files did assume newlines before
each (name, word vector) pair. The Google News Corpus doesn't have these
and hence it failed to load the file. Gensim simply assumes no newlines
and strips them, if it they occur. This crate now does the same.
If you accept this PR, please make a bug fix release.