Add Creator/Custom Design Items #189
Conversation
|
Hello, love the feature. But in the collection screen, this segmented control will crop the label on top. If you try on an iPhone 8 for example. Or a landscape iPad. Maybe it's not the right place to be or maybe we have to rework the top selector to something custom. I'll review the code shortly. |
Oops :-) Do you have any suggestion for the ui/ux, @Dimillian? I can give it a try. |
I have suggestion and will implement and propose it later tonight. |
|
Yes sorry didn't had time to think about it yet. Can't wait to see your proposition. |
|
What about having a |
|
I like it. I would move critters into the more tab and leave the custom lists as it is. We already have a whole critters section in the dashboard. And List have a subscribe call :p |
## Description Sometimes it's hard to keep track of creators and items we want to follow or clothes and patterns we want to use. A good place to track these information would be in the companion application. ## Implementation The main types added by this commit are: - `Design`: simple model with title, code, and description. - `DesignRowView` and `DesignRowViewModel`: view and view model used tp populate the table - `DesignFormView` and `DesignFormViewModel`: view and view model used to add a new design to the list. This commit also touches the caching layer, adding designs as an optional array.
# Conflicts: # ACHNBrowserUI/ACHNBrowserUI/views/shared/Sheet.swift
# Conflicts: # ACHNBrowserUI/ACHNBrowserUI/views/shared/Sheet.swift
# Conflicts: # ACHNBrowserUI/ACHNBrowserUI/views/userLists/UserListDetailView.swift
|
I've added the "More" tab and moved Critters and Designs there. Let me know what you think, @Dimillian, @renaudjenny. |
|
Awesome !!!! I guess this will land in master very soon :) |
|
@otaviocc awesome! Can't wait to have this on the app. |
| List { | ||
| CollectionMoreDetailView(viewModel: CollectionMoreDetailViewModel()) | ||
| } | ||
| .previewLayout(.sizeThatFits) |
There was a problem hiding this comment.
That's smart. I've never think about this one!
|
Making few fixes for localization and merging, great works! |
Description
There are so many creators and custom designs to track and try that sometimes it's hard to keep track of them. A good place to store these information would be in this companion app.
Implementation
The main types added by this commit are:
Design: simple model with title, code, and description.DesignRowViewandDesignRowViewModel: view and view model used to populate the table.DesignFormViewandDesignFormViewModel: view and view model used to add a new design to the list.This commit also touches the caching layer, adding designs as an optional array.
Screenshots
Demo
In case of bugs, I can help Blathers on that.