New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Custom Chores and To-Dos #210
Conversation
This commit adds custom Chores and To-Dos to the Dashboard. This feature complements the Daily Tasks Section. It adds a way for the user to track chores and other actions they have to do when playing. For instance: - Send a card to a friend - Build an specific gift to a villager - Sell scoprions to Flick - Etc...
Awesome! Integrated TODOs list :D. Love that! |
ACHNBrowserUI/ACHNBrowserUI/viewModels/ChoreFormViewModel.swift
Outdated
Show resolved
Hide resolved
ACHNBrowserUI/ACHNBrowserUI/packages/Backend/Sources/Backend/environments/UserCollection.swift
Outdated
Show resolved
Hide resolved
I think they don't overlap, you video examples for instance are very good, like going to my wife's island to sell turnips, etc. |
When I was working on it, I thought of making it automatically reset everyday at 5am (new day). But then I decided to make it a to-do list, to track things I have to do but don't have an specific date to finish. That's why I added an open description field as well. |
By the way, I tried to avoid using UserCollection inside the views. Since it is more like a model or a repository. I moved all the logic to the view model. That's why there are some computed properties to show/hide things and compute the ratio of task to do and done. |
Yes good call. Also referencing user collection on the view will cause an over refresh. Will take a look at this PR after the one from @TheVaan :) I agree that the two can cohabit. |
I agree to @renaudjenny's comment, that this is a really nice addition as a todo list. I would like if it works a little bit like Apples Reminders app so you can have todos that are returning and todos that remove their self after finishing. E.g. I add a todo "Pay 100.000 bells to bridge droid" - after finishing that, I want it to disappear form the list. Maybe just hide it (with a show button to see old todos) so it will still be counted on the widget. Adding a "clean up" button to remove all finished tasks could also be an option, if there are to many finished, not returning tasks. Just a few ideas I thought about. No must-haves. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything in the code looks fine to me. Hence approving this PR.
That's a good point. How about adding the timezone to the Island setup (Preferences). It already holds the island name, native fruit, hemisphere. I liked your suggestions for the to-to! I'll work on that in a separate PR. Thanks! |
Merging, this is good! |
This commit adds custom Chores and To-Dos to the Dashboard.
This feature complements the Daily Tasks Section. It adds a way for the user to track chores and other actions they have to do when playing. For instance:
Think of it as todo app inside the app :-)