Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Custom Chores and To-Dos #210

Merged
merged 3 commits into from May 31, 2020
Merged

Add Custom Chores and To-Dos #210

merged 3 commits into from May 31, 2020

Conversation

otaviocc
Copy link
Contributor

@otaviocc otaviocc commented May 31, 2020

This commit adds custom Chores and To-Dos to the Dashboard.

This feature complements the Daily Tasks Section. It adds a way for the user to track chores and other actions they have to do when playing. For instance:

  • Send a card to a friend
  • Build an specific gift to a villager
  • Sell scorpions to Flick
  • Etc...

Think of it as todo app inside the app :-)

output

This commit adds custom Chores and To-Dos to the Dashboard.

This feature complements the Daily Tasks Section. It adds a way for the user to track chores and other actions they have to do when playing. For instance:

- Send a card to a friend
- Build an specific gift to a villager
- Sell scoprions to Flick
- Etc...
@renaudjenny
Copy link
Collaborator

Awesome! Integrated TODOs list :D. Love that!

@Dimillian
Copy link
Owner

While I love it @TheVaan build it on top of his previous system: #209 so I'll take a look and merge it first :)

@otaviocc
Copy link
Contributor Author

While I love it @TheVaan build it on top of his previous system: #209 so I'll take a look and merge it first :)

Oops I missed that. I didn't know/see that. I'm sorry. :-(

@renaudjenny
Copy link
Collaborator

I think they don't overlap, you video examples for instance are very good, like going to my wife's island to sell turnips, etc.
But I do think they will be few overlapping in code (I think some of your removals are used by @TheVaan), it worths a double check.
And I agree with @Dimillian, we should wait @TheVaan PR to be merged first, I think it will be easier to resolve conflicts for you as you mainly created new files.

@otaviocc
Copy link
Contributor Author

I think they don't overlap, you video examples for instance are very good, like going to my wife's island to sell turnips, etc.
But I do think they will be few overlapping in code (I think some of your removals are used by @TheVaan), it worths a double check.
And I agree with @Dimillian, we should wait @TheVaan PR to be merged first, I think it will be easier to resolve conflicts for you as you mainly created new files.

When I was working on it, I thought of making it automatically reset everyday at 5am (new day). But then I decided to make it a to-do list, to track things I have to do but don't have an specific date to finish. That's why I added an open description field as well.

@otaviocc
Copy link
Contributor Author

otaviocc commented May 31, 2020

By the way, I tried to avoid using UserCollection inside the views. Since it is more like a model or a repository. I moved all the logic to the view model. That's why there are some computed properties to show/hide things and compute the ratio of task to do and done.

@Dimillian
Copy link
Owner

Yes good call. Also referencing user collection on the view will cause an over refresh. Will take a look at this PR after the one from @TheVaan :) I agree that the two can cohabit.

@TheVaan
Copy link
Collaborator

TheVaan commented May 31, 2020

I agree to @renaudjenny's comment, that this is a really nice addition as a todo list.
To pick up your 5am-reset-idea: I had this for my Todays Tasks Widget, but we decided that we don't know the time of the island so it may not be correct when we reset this at 5am device time.

I would like if it works a little bit like Apples Reminders app so you can have todos that are returning and todos that remove their self after finishing. E.g. I add a todo "Pay 100.000 bells to bridge droid" - after finishing that, I want it to disappear form the list. Maybe just hide it (with a show button to see old todos) so it will still be counted on the widget. Adding a "clean up" button to remove all finished tasks could also be an option, if there are to many finished, not returning tasks. Just a few ideas I thought about. No must-haves.

Copy link
Collaborator

@renaudjenny renaudjenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything in the code looks fine to me. Hence approving this PR.

@otaviocc
Copy link
Contributor Author

To pick up your 5am-reset-idea: I had this for my Todays Tasks Widget, but we decided that we don't know the time of the island so it may not be correct when we reset this at 5am device time.

That's a good point. How about adding the timezone to the Island setup (Preferences). It already holds the island name, native fruit, hemisphere.

I liked your suggestions for the to-to! I'll work on that in a separate PR. Thanks!

@Dimillian
Copy link
Owner

Merging, this is good!

@Dimillian Dimillian merged commit fae875a into Dimillian:master May 31, 2020
@otaviocc otaviocc deleted the todo branch May 31, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants