Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media continues to play when not in focus #386

Open
reconbot opened this issue Jan 25, 2023 · 6 comments
Open

Media continues to play when not in focus #386

reconbot opened this issue Jan 25, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@reconbot
Copy link

I write this issue while listening to a video from a status of mine. I noticed it’s playing in a “favorite” notification but I was unable to pause it. I’ve navigated to settings/GitHub and it’s still playing. Refreshing the notification list doesn’t stop it from playing either. I was able to start playing a second instance of this video as well.

@LorenAmelang
Copy link

Mine this morning, with 1.0.11, was a bit weirder... This post appeared in my timeline:

https://mastodon.lol/@janusrose/109748096934229247

I scrolled down and tapped the Twitter link:

https://twitter.com/janusrose/status/1617997367558668288

It opened in a browser window. I ignored the Twitter "Use the app" dialog, didn't choose either option. Tapped Play and it played. Closed back to the IceCubes post and it still played! Poked around all over IceCubes and the nasty siren still played! Hard killed IceCubes - still played. Hard killed Safari (no sign of it there) and other apps - still played. Finally had to turn the iPhone (SE2020, 16.2) completely off!

Is there some way to kill such bits of rogue code that won't die with the app that created them?

@Dimillian Dimillian added the bug Something isn't working label Jan 26, 2023
@jwhitley
Copy link

Same as prior comment in 1.1.2. Another repro example, same steps as above:

https://mastodon.social/@rands/109763992096939372

Based on the same bug in other apps, it’s probably that the SFSafariViewController in SafariRouter.swift isn’t getting cleaned up properly when the user closes the dialog with the “Done” button.

@jwhitley
Copy link

Super quick take, this probably needs to add .onDisappear in SafariRouter.body().

@LorenAmelang
Copy link

In 1.1.3 I watched the linked video in this post:
https://mastodon.world/@faustosterling/109763929234938403

It ended, I closed back to my timeline, read for maybe a half hour with no odd events. Switched to a different instance, read some more...

Clicked the Quanta Magazine link in this post:
https://neuromatch.social/@skarthik/109763492531363230

It opened for a flash in non-reader mode and then switched to reader - and began playing audio from what sounded like a news channel on YouTube! That lasted for a minute or so, they were just concluding whatever it was and signing off.

No more audio appeared, but my default on YouTube is not to automatically play the next algorithm hit. I tried a few more times to open timeline web links, and didn't trigger any more audio. But is some code fragment sitting out there waiting to be triggered by whatever started the first audio?

@jonathankoren
Copy link

jonathankoren commented May 23, 2023

Still occurs in 1.6.15 . Essentially any media play will get multiple copies running simultaneously, with no controls nor obvious way to stop it.

@Okkarator
Copy link

I just noticed this bug on iOS version 1.6.15 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Bugs
Development

No branches or pull requests

6 participants