Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StreamToHandshake] Fix EOS handling for map and filter #2

Closed
Dinistro opened this issue May 30, 2022 · 0 comments · Fixed by #6
Closed

[StreamToHandshake] Fix EOS handling for map and filter #2

Dinistro opened this issue May 30, 2022 · 0 comments · Fixed by #6

Comments

@Dinistro
Copy link
Owner

We have to ensure that we fix the EOS semantics and then we have to either update the driver or the operators.

There are two approaches I can see here:

  1. Ensure that the two signals are emitted in the same cycle.
  2. Ensure that the client does consider the tuple before taking care of the next EOS value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tuple and eos single hs Dinistro/circt-stream
1 participant
@Dinistro