Some code/documentation is hardcoded with the prefix /opt/dionaea

[xambroz]

ISSUE TYPE

• Bug Report
• Feature Idea
• Documentation Report

DIONAEA VERSION

0.8.0
baf25d6d40db7018562e22c03b60b4f43317f206

CONFIGURATION

n/a/

OS / ENVIRONMENT

• Github / code-review

SUMMARY

Some code and documentation contains hardcoded /opt/dionaea string. According to #168 this should have been fixed moving to cmake, but there are still files where this is hardcoded.
Affected are:
modules/python/util/readlogsqltree.py
modules/python/util/gnuplotsql.py

doc/html/index.html
doc/source/run.rst
doc/source/faq.rst
doc/source/installation.rst
doc/source/tips_and_tricks.rst
doc/source/development/setup.rst
doc/source/old/configuration.rst
doc/source/old/seagfaults.rst
doc/source/old/utils.rst
doc/source/migration.rst

STEPS TO REPRODUCE

grep -R /opt/dionaea * |grep -v cmake

EXPECTED RESULTS

I expect that path such as /opt/dionaea or /usr/local/ or /chroot/dionaea will get to the code and generated documentation with the prefix parameter to the cmake such as
cmake -DCMAKE_INSTALL_PREFIX:PATH=/opt/dionaea

ACTUAL RESULTS

[xambroz]

BTW it is not only about the prefix, but about location of the files for example:
modules/python/util/readlogsqltree.py: dbpath = '/opt/dionaea/var/dionaea/logsql.sqlite'

In instalation to prefix of /usr I would actually like to see the logsql.sqlite to be installed in /var/lib/dionaea and not just /var/dionaea/ so the file hierarchy matches other software like postgresql having data files in the /var/lib/pgsql.

Such configuration shuld really come from the cmake defaults or runtime options rather then being hardcoded in the scripts.

[xambroz]

Still issue in 0.11.0
modules/python/util/gnuplotsql.py: dest="database", default="/opt/dionaea/var/dionaea/logsql.sqlite")
modules/python/util/readlogsqltree.py: dbpath = '/opt/dionaea/var/dionaea/logsql.sqlite'