Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing components with hotreloading enabled can lead to page crash #2077

Open
3 tasks
jkelleyrtp opened this issue Mar 13, 2024 · 0 comments
Open
3 tasks
Labels
bug Something isn't working hot-reload Related to the hot reload crate

Comments

@jkelleyrtp
Copy link
Member

Problem

If you have a series of components and remove one or multiple of them, the hotreloading resolver in core will crash, presumably because the scope we've removed no longer exists during reconciliation.

Not sure what the solution is.

rsx! {
    div {
        Child {}
        Child {}
        Child {}
    }
}

Environment:

  • Dioxus version: [e.g. v0.17, master]
  • Rust version: [e.g. 1.43.0, nightly]
  • OS info: [e.g. MacOS]
  • App platform: [e.g. web, desktop]

Questionnaire

  • I'm interested in fixing this myself but don't know where to start
  • I would like to fix and I have a solution
  • I don't have time to fix this right now, but maybe later
@jkelleyrtp jkelleyrtp added the hot-reload Related to the hot reload crate label Mar 13, 2024
@jkelleyrtp jkelleyrtp modified the milestone: 0.5.0: Signals Mar 13, 2024
@jkelleyrtp jkelleyrtp added the bug Something isn't working label Mar 13, 2024
@jkelleyrtp jkelleyrtp added this to the 0.6.0: Devtools milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hot-reload Related to the hot reload crate
Projects
None yet
Development

No branches or pull requests

1 participant