Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supplement generated tests with a fuzzing framework #133

Open
alice-i-cecile opened this issue Jun 10, 2022 · 2 comments
Open

Supplement generated tests with a fuzzing framework #133

alice-i-cecile opened this issue Jun 10, 2022 · 2 comments
Labels
build system Make continuous integration do the tedious things code quality Make the code cleaner or prettier.

Comments

@alice-i-cecile
Copy link
Collaborator

alice-i-cecile commented Jun 10, 2022

  1. The test generating code is broken, and hard to maintain, see Fix test generation #89 and Fix cargo run --package gentest #65.
  2. The automatic tests are massive, resulting in painful renames.
  3. This strategy is extremely hard to apply to alternative layout strategies (Support multiple layout algorithms #28).
  4. These generated tests aren't even complete, and have failed to catch multiple deviations from the spec.

These should be supplemented with a fuzz testing or property-based testing framework.

@alice-i-cecile alice-i-cecile added code quality Make the code cleaner or prettier. build system Make continuous integration do the tedious things labels Jun 10, 2022
@alice-i-cecile
Copy link
Collaborator Author

Checking for Chrome compliance was a solid idea though, and should be retained in CI.

@mockersf
Copy link
Contributor

I re-added (and fixed) the gentest script in #145. I believe it can't be replaced by fuzzing or prop testing, as both those techniques would need a third party flexbox implementation to generate the assertions anyway.

@alice-i-cecile alice-i-cecile changed the title Replace generated tests with a fuzzing framework Supplement generated tests with a fuzzing framework Jun 11, 2022
@alice-i-cecile alice-i-cecile added good first issue Good for newcomers and removed good first issue Good for newcomers labels Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system Make continuous integration do the tedious things code quality Make the code cleaner or prettier.
Projects
None yet
Development

No branches or pull requests

2 participants