Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Display::FlowRoot #484

Open
nicoburns opened this issue May 18, 2023 · 0 comments
Open

Support Display::FlowRoot #484

nicoburns opened this issue May 18, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nicoburns
Copy link
Collaborator

What problem does this solve or what need does it fill?

display: flow-root nodes use the same algorithm as CSS Block layout, except that they force the creation of a new https://developer.mozilla.org/en-US/docs/Web/Guide/CSS/Block_formatting_context. In practice the main impact of this will be to prevent margin collapsing between the Display::FlowRoot node and it's children, or through the Display::FlowRoot node. If in future we support floats, it would also affect those.

What solution would you like?

Implement support for Display::FlowRoot in Taffy, by adding a new variant to the Display enum and updating the Block Layout implementation to work with it.

@nicoburns nicoburns added enhancement New feature or request good first issue Good for newcomers labels May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant