Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to ensure that random numbers are generated correctly for caching #15

Merged
merged 2 commits into from Oct 6, 2022
Merged

Fix to ensure that random numbers are generated correctly for caching #15

merged 2 commits into from Oct 6, 2022

Conversation

jivjen
Copy link
Contributor

@jivjen jivjen commented Oct 6, 2022 •
edited

Description:

This fix aims at tackling the below two points as mentioned in #14 :

  • Ensuring that the generation of numbers happens within the range 0-19 and not 1 to 20
  • Ensuring that the numbers are unique and do not repeat themselves

This fix also addresses the issue mentioned in #16

Tested the same for all the different caching algorithms and they are working fine.

@jivjen jivjen mentioned this pull request Oct 6, 2022
Closed
Diptonil
Diptonil approved these changes Oct 6, 2022
View reviewed changes
Copy link
Owner

@Diptonil Diptonil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The process that you have used is something that I did not know previously. Thank you for sharing this approach, @jivjen.

@Diptonil Diptonil merged commit ac147aa into Diptonil:main Oct 6, 2022
@Diptonil
Copy link
Owner

Diptonil commented Oct 6, 2022

Issues #16 and #15 resolved.

@Diptonil Diptonil added hacktoberfest Issue or PR is marked for Hacktoberfest. hacktoberfest-accepted Issue or PR is accepted for Hacktoberfest. labels Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Diptonil Diptonil Diptonil approved these changes

Assignees
No one assigned
Labels
hacktoberfest Issue or PR is marked for Hacktoberfest. hacktoberfest-accepted Issue or PR is accepted for Hacktoberfest.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jivjen @Diptonil