Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add send_voice_messages permission #1006

Merged
merged 9 commits into from May 23, 2023
Merged

Conversation

onerandomusername
Copy link
Member

Summary

Adds the new permission for sending voice messages.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@onerandomusername onerandomusername added t: enhancement New feature t: api support Support of Discord API features s: needs review Issue/PR is awaiting reviews labels Apr 16, 2023
@onerandomusername onerandomusername added this to the disnake v2.9 milestone Apr 16, 2023
@shiftinv
Copy link
Member

This should be combined with the other voice message related changes, and have one changelog entry for the permission bit + other fields.
I've pushed the other things here, would be great if you could pull them into this PR.

@onerandomusername
Copy link
Member Author

This should be combined with the other voice message related changes, and have one changelog entry for the permission bit + other fields. I've pushed the other things here, would be great if you could pull them into this PR.

I'd rather get the permission in now, as that doesn't require much of a review.

@shiftinv
Copy link
Member

I'd rather get the permission in now, as that doesn't require much of a review.

Fine, I suppose.

Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not having send_messages permissions should implicitly deny send_voice_messages:
image

@onerandomusername
Copy link
Member Author

Not having send_messages permissions should implicitly deny send_voice_messages: image

Fair, I forgot about this because that is part of the code is completely wrong.

changelog/1006.feature.rst Outdated Show resolved Hide resolved
disnake/permissions.py Show resolved Hide resolved
disnake/permissions.py Outdated Show resolved Hide resolved
disnake/permissions.py Outdated Show resolved Hide resolved
onerandomusername and others added 5 commits May 11, 2023 04:45
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: arl <me@arielle.codes>
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: arl <me@arielle.codes>
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ty

@shiftinv shiftinv merged commit 5f368e9 into master May 23, 2023
24 checks passed
@shiftinv shiftinv deleted the feat/voice-message-perm branch May 23, 2023 11:40
@shiftinv shiftinv mentioned this pull request May 23, 2023
8 tasks
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: api support Support of Discord API features t: enhancement New feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants