Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forumchannel): set attachment data correctly #1008

Merged
merged 3 commits into from May 21, 2023

Conversation

shiftinv
Copy link
Member

Summary

When creating a forum thread, the "attachments" field was previously being added to the payload at the top level, instead of in the nested "message" field.
This prevented creation of forum threads with just files (works fine if you add embeds, content, or anything else), and also meant that file descriptions wouldn't be sent if you hadn't already hit the first issue.

To reproduce:

await forum_channel.create_thread(
    name="attachment test",
    file=disnake.File("/path/to/file"),
)

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added this to the disnake v2.9 milestone Apr 16, 2023
@shiftinv shiftinv merged commit b4c134e into master May 21, 2023
24 checks passed
@shiftinv shiftinv deleted the fix/forum-thread-create-files branch May 21, 2023 18:19
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants