Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auditlog): support threads in extra attribute #1009

Merged
merged 6 commits into from Jun 18, 2023
Merged

fix(auditlog): support threads in extra attribute #1009

merged 6 commits into from Jun 18, 2023

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented Apr 17, 2023 •
edited

Summary

Some audit log actions previously used get_channel instead of get_channel_or_thread, which is needed for things like message_delete actions in threads.

Originally part of (and depends on) #995, now moved into a separate PR (this one).

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added s: blocked Issue/PR is blocked by other issues s: needs review Issue/PR is awaiting reviews t: bugfix labels Apr 17, 2023
@shiftinv shiftinv added this to the disnake v2.9 milestone Apr 17, 2023
@shiftinv shiftinv mentioned this pull request Apr 17, 2023
Merged
8 tasks
Base automatically changed from fix/auditlog to master April 28, 2023 14:51
@shiftinv shiftinv removed the s: blocked Issue/PR is blocked by other issues label Apr 28, 2023
@shiftinv @onerandomusername
docs(changelog): improve phrasing
f8c78be 
Co-authored-by: arl <me@arielle.codes>
Signed-off-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
@shiftinv shiftinv enabled auto-merge (squash) June 18, 2023 19:40
@shiftinv shiftinv merged commit 384fb0e into master Jun 18, 2023
24 checks passed
@shiftinv shiftinv deleted the fix/auditlog-threads branch June 18, 2023 19:46
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skelmis Skelmis Skelmis approved these changes

@Victorsitou Victorsitou Victorsitou approved these changes

@onerandomusername onerandomusername Awaiting requested review from onerandomusername

Assignees
No one assigned
Labels
t: bugfix
Projects
disnake
Status: Done
Milestone
disnake v2.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shiftinv @Skelmis @Victorsitou @onerandomusername