Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interactions): support delete_after for edits #1014

Merged
merged 9 commits into from Jul 14, 2023

Conversation

shiftinv
Copy link
Member

Summary

Resolves #973.
This is already possible by calling .delete_original_response(delay=) afterwards, but an edit parameter is slightly more convenient.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: enhancement New feature p: low Low priority s: needs review Issue/PR is awaiting reviews labels Apr 25, 2023
@onerandomusername onerandomusername added this to the disnake v2.9 milestone Jun 18, 2023
@shiftinv shiftinv modified the milestones: disnake v2.9, disnake v2.10 Jun 18, 2023
@shiftinv shiftinv enabled auto-merge (squash) July 14, 2023 18:38
@shiftinv shiftinv merged commit 1c52fe0 into master Jul 14, 2023
23 checks passed
@shiftinv shiftinv deleted the feature/interaction-edit-delete-after branch July 14, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: low Low priority s: needs review Issue/PR is awaiting reviews t: enhancement New feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

delete_after in interaction responses
4 participants