Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Cog): raise error if InteractionBot has prefix commands related things #1018

Merged
merged 5 commits into from May 7, 2023
Merged

fix(Cog): raise error if InteractionBot has prefix commands related things #1018

merged 5 commits into from May 7, 2023

Conversation

Victorsitou
Copy link
Member

Summary

just a better error message to avoid this one
image

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Victorsitou Victorsitou added s: needs review Issue/PR is awaiting reviews t: bugfix labels Apr 29, 2023
@Victorsitou Victorsitou added this to the disnake v2.9 milestone Apr 29, 2023
Skelmis
Skelmis approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@Skelmis Skelmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

shiftinv
shiftinv approved these changes May 7, 2023
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@shiftinv shiftinv merged commit 8d661e9 into DisnakeDev:master May 7, 2023
24 checks passed
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftinv shiftinv shiftinv approved these changes

@Skelmis Skelmis Skelmis approved these changes

Assignees
No one assigned
Labels
t: bugfix
Projects
disnake
Status: Done
Milestone
disnake v2.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Victorsitou @shiftinv @Skelmis @onerandomusername