New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(enum): deprecates Party Type enum (#1023) #1035
fix(enum): deprecates Party Type enum (#1023) #1035
Conversation
Signed-off-by: Known Black Hat <65008967+KnownBlackHat@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The enum should be deprecated rather than removed to avoid breaking changes
yep doing that rn |
Signed-off-by: Known Black Hat <65008967+KnownBlackHat@users.noreply.github.com>
0ae9b85
to
59b44c1
Compare
Signed-off-by: Known Black Hat <65008967+KnownBlackHat@users.noreply.github.com>
59b44c1
to
d6db29d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add a deprecation note (.. deprecated:: 2.9
etc.) below here, similar to other deprecation notes?
Lines 111 to 113 in 473bafb
.. class:: PartyType | |
Represents the type of a voice channel activity/application. |
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com> Signed-off-by: Known Black Hat <65008967+KnownBlackHat@users.noreply.github.com>
Signed-off-by: Known Black Hat <65008967+KnownBlackHat@users.noreply.github.com>
Signed-off-by: Known Black Hat <65008967+KnownBlackHat@users.noreply.github.com>
Signed-off-by: Known Black Hat <65008967+KnownBlackHat@users.noreply.github.com>
Summary
Deprecates the
PartyType
enumPartyType
enum #1023Checklist
pdm lint
pdm pyright