Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update info about Bot account creation process #1039

Merged
merged 6 commits into from May 21, 2023
Merged

docs: Update info about Bot account creation process #1039

merged 6 commits into from May 21, 2023

Conversation

elenakrittik
Copy link
Contributor

Summary

This PR updates the Creating a Bot Account page according to latest changes made by Discord.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@elenakrittik elenakrittik marked this pull request as ready for review May 19, 2023 08:22
@shiftinv shiftinv added t: documentation Improvements or additions to documentation/examples s: needs review Issue/PR is awaiting reviews labels May 19, 2023
spifory
spifory suggested changes May 19, 2023
View reviewed changes
Copy link
Contributor

@spifory spifory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want to update the pictures as well since they're a little inconsistent with your change.
Screenshot from 2023-05-19 10-04-09

docs/discord.rst Outdated Show resolved Hide resolved
elenakrittik and others added 2 commits May 19, 2023 19:26
@elenakrittik @spifory
Update docs/discord.rst
fe6f324 
Co-authored-by: toolifelesstocode <luvuyosilubane50@gmail.com>
Signed-off-by: pew; <77104725+ItsAleph@users.noreply.github.com>
@elenakrittik
docs: Update images
2afcf36
@elenakrittik
Copy link
Contributor Author

Updated images + (maybe?) increased quality a bit.

shiftinv
shiftinv approved these changes May 21, 2023
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for updating this and improving the images :>

@shiftinv shiftinv enabled auto-merge (squash) May 21, 2023 18:33
@shiftinv shiftinv merged commit 09fce91 into DisnakeDev:master May 21, 2023
24 checks passed
@elenakrittik elenakrittik deleted the docs/update-info branch May 22, 2023 19:25
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Jun 12, 2023
@onerandomusername onerandomusername added this to the disnake v2.9 milestone Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spifory spifory spifory requested changes

@shiftinv shiftinv shiftinv approved these changes

Assignees
No one assigned
Labels
t: documentation Improvements or additions to documentation/examples
Projects
disnake
Status: Done
Milestone
disnake v2.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@elenakrittik @shiftinv @spifory @onerandomusername