Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: further username system updates #1044

Merged
merged 10 commits into from Jun 12, 2023

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented Jun 7, 2023

Summary

continuation of #1025, incorporating the new updates from discord/discord-api-docs@6e9622b

Changes:

  • Calculate default avatars of migrated users using mod 6 instead of 5, which results in the fuchsia/pink default avatar now being used (woo \o/)
  • Revert the "bot display name = application name" part of the documentation, as Discord has now decided against it
  • Clarify other parts of the documentation regarding bot users not getting pomelo'd (for now)

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: enhancement New feature t: api support Support of Discord API features s: needs review Issue/PR is awaiting reviews t: bugfix labels Jun 7, 2023
@shiftinv shiftinv added this to the disnake v2.9 milestone Jun 7, 2023
disnake/enums.py Show resolved Hide resolved
disnake/member.py Outdated Show resolved Hide resolved
disnake/user.py Outdated Show resolved Hide resolved
disnake/user.py Show resolved Hide resolved
disnake/user.py Outdated Show resolved Hide resolved
@onerandomusername onerandomusername enabled auto-merge (squash) June 12, 2023 18:31
@onerandomusername onerandomusername merged commit 7ada78d into master Jun 12, 2023
24 checks passed
@onerandomusername onerandomusername deleted the feat/pomelo-2-electric-boogaloo branch June 12, 2023 18:43
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: api support Support of Discord API features t: bugfix t: enhancement New feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants