Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support media channels #1050

Merged
merged 34 commits into from Feb 13, 2024
Merged

feat: support media channels #1050

merged 34 commits into from Feb 13, 2024

Conversation

onerandomusername
Copy link
Member

@onerandomusername onerandomusername commented Jun 15, 2023 •
edited by shiftinv

Summary

Untested, I don't have access to media channels.

Tested now.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@onerandomusername onerandomusername added t: enhancement New feature t: api support Support of Discord API features s: waiting for api/docs Issue/PR is waiting for API support/documentation labels Jun 15, 2023
@onerandomusername onerandomusername added this to the disnake v2.9 milestone Jun 15, 2023
shiftinv
shiftinv reviewed Jun 15, 2023
View reviewed changes
disnake/channel.py Outdated Show resolved Hide resolved
@shiftinv shiftinv modified the milestones: disnake v2.9, disnake v2.10 Jun 16, 2023
@Victorsitou Victorsitou added the s: needs review Issue/PR is awaiting reviews label Jun 17, 2023
Victorsitou
Victorsitou reviewed Jun 17, 2023
View reviewed changes
disnake/flags.py Outdated Show resolved Hide resolved
disnake/state.py Show resolved Hide resolved
disnake/webhook/async_.py Outdated Show resolved Hide resolved
@onerandomusername onerandomusername marked this pull request as ready for review June 18, 2023 19:48
@shiftinv shiftinv removed the s: waiting for api/docs Issue/PR is waiting for API support/documentation label Aug 1, 2023
shiftinv and others added 6 commits August 2, 2023 00:54
@shiftinv
revert: "refactor channel webhooks to a mixin"
3e5ed18 
This reverts commit 05cf41b.
@shiftinv
chore: run codemod
8f64746
@shiftinv
chore(docs): update versionadded
91f381a
@onerandomusername
Merge branch 'master' into feat/media-channel
5ad01f3
@shiftinv
Merge remote-tracking branch 'upstream/master'
8751aef
@shiftinv
refactor: drop create_thread impls in derived classes
b2ca01e 
The only differences were `versionadded` and forum/media channel phrasing in the documentation,
which I couldn't care less about if it reduces the diff by 500 lines
@shiftinv
chore: move comment to correct location
7b08757
@shiftinv
fix: move default_layout to ForumChannel, fix return annotations`
d779a93
@shiftinv
fix: add missing _fill_overwrites call
ddf89b4
@shiftinv
chore: implement _get_channel in base type
b35840d
@shiftinv
refactor: implement typing in base type
b9b8a17
@shiftinv
nit: is forumable even a word
f560631
@shiftinv
fix: handle media channels in Message.system_content
972f4cd
@shiftinv
chore: rename disnake.types.channel._BaseForumGuildChannel
aeaef9a
@shiftinv
fix: consider media channels in audit log tag_id fallback
413c051
@shiftinv
docs: clarify that media channels are essentially fancy forum channels
dcfbbaa
@shiftinv
fix: add missing attributes for accessing/creating media channels
9e7fc7c
@shiftinv
docs: add missing media channel docs, update docs that previously onl…
60ae8bd 
…y referred to forum channels
@shiftinv
feat: add MediaChannel.hides_media_download_options shortcut
7546350
@shiftinv shiftinv merged commit 23d9106 into master Feb 13, 2024
27 checks passed
@shiftinv shiftinv deleted the feat/media-channel branch February 13, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftinv shiftinv shiftinv left review comments

@Victorsitou Victorsitou Victorsitou left review comments

Assignees
No one assigned
Labels
s: needs review Issue/PR is awaiting reviews t: api support Support of Discord API features t: enhancement New feature
Projects
disnake
Status: Done
Milestone
disnake v2.10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@onerandomusername @shiftinv @Victorsitou