Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add disclaimer about creating >30d invites #1056

Merged
merged 8 commits into from Jun 18, 2023
Merged

docs: add disclaimer about creating >30d invites #1056

merged 8 commits into from Jun 18, 2023

Conversation

onerandomusername
Copy link
Member

Summary

Adds simple documentation note about the new 30d invite link day limit.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@onerandomusername onerandomusername added the t: documentation Improvements or additions to documentation/examples label Jun 18, 2023
@onerandomusername onerandomusername added this to the disnake v2.9 milestone Jun 18, 2023
Victorsitou
Victorsitou reviewed Jun 18, 2023
View reviewed changes
disnake/abc.py Outdated Show resolved Hide resolved
disnake/abc.py Outdated Show resolved Hide resolved
@onerandomusername onerandomusername added the s: needs review Issue/PR is awaiting reviews label Jun 18, 2023
shiftinv
shiftinv reviewed Jun 18, 2023
View reviewed changes
disnake/abc.py Outdated Show resolved Hide resolved
@onerandomusername @shiftinv
Update disnake/abc.py
fe7e8d3 
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: arl <me@arielle.codes>
@onerandomusername onerandomusername merged commit c71baf0 into master Jun 18, 2023
24 checks passed
@onerandomusername onerandomusername deleted the docs/30d-invites branch June 18, 2023 21:41
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Jun 18, 2023
shiftinv added a commit that referenced this pull request Dec 8, 2023
@shiftinv
revert: "docs: add disclaimer about creating >30d invites (#1056)"
fb9434b 
This reverts commit c71baf0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Victorsitou Victorsitou Victorsitou approved these changes

@shiftinv shiftinv shiftinv approved these changes

Assignees
No one assigned
Labels
t: documentation Improvements or additions to documentation/examples
Projects
disnake
Status: Done
Milestone
disnake v2.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@onerandomusername @shiftinv @Victorsitou