Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webhook): improve thread support for webhook messages #1077

Merged
merged 4 commits into from Jan 20, 2024

Conversation

shiftinv
Copy link
Member

Summary

Adds a thread parameter to Webhook.fetch_message, edit_message, and delete_message, and handles this appropriately in WebhookMessage.edit/.delete.
Previously, threads were only fully supported in Webhook.send.

context: https://canary.discord.com/channels/808030843078836254/942319505915412500/1129444052035698768

discord/discord-api-docs@528975f

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: enhancement New feature t: api support Support of Discord API features s: needs review Issue/PR is awaiting reviews labels Jul 14, 2023
@shiftinv shiftinv added this to the disnake v2.10 milestone Jan 20, 2024
@shiftinv shiftinv merged commit 4da720d into master Jan 20, 2024
27 checks passed
@shiftinv shiftinv deleted the feature/webhook-more-threads branch January 20, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: needs review Issue/PR is awaiting reviews t: api support Support of Discord API features t: enhancement New feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant